refactor: Session->checkAction method #1214
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@grimpirate Please run command: composer cs-fix |
Contributor
Author
|
Please make the edit to include spaces after the not (!) operators. I don't have a local environment with GPG signing set up for this. I make these changes via the github online editor so I lack the capability to squash commits together and other such features. Thank you. |
datamweb
reviewed
Nov 2, 2024
Contributor
Author
|
Closing this because of inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The checkAction method of the Session authenticator class includes unneeded assignment statements and comparisons. No functional change.
Checklist: